Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet)

ios/MullvadVPN/View controllers/Preferences/CustomDNSDataSource.swift line 247 at r1 (raw file):

    // MARK: - UITableViewDelegate

    func tableView(_ tableView: UITableView, shouldHighlightRowAt indexPath: IndexPath) -> Bool {

Do we need this?

ios/MullvadVPN/View controllers/Preferences/CustomDNSDataSource.swift line 358 at r1 (raw file):

    private func updateSnapshot(animated: Bool = false, completion: (() -> Void)? = nil) {
        var newSnapshot = NSDiffableDataSourceSnapshot<Section, Item>()
        let oldSnapshot = snapshot()

Diffdatasource figures things out this internally and does the diffing by itself, so I think we should remove oldSnapshot and get the identifiers from Item enum directly instead.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rablador)

ios/MullvadVPN/View controllers/Preferences/CustomDNSDataSource.swift line 247 at r1 (raw file):

highlightedRows.mov
This is what happens if we don't have it (notice how the rows change colors as I tap on them)

ios/MullvadVPN/View controllers/Preferences/CustomDNSDataSource.swift line 358 at r1 (raw file):

I tried to implement that, but it didn't work.

My understanding is that we still need the old snapshot when we collapse sections, and when we toggle editing mode to avoid the section collapsing if was expanded prior to that I think.

Or maybe I misunderstood your suggestion, how would it look ?

Here's what I tried

var newSnapshot = NSDiffableDataSourceSnapshot<Section, Item>()
newSnapshot.appendSections(Section.allCases)
newSnapshot.appendItems(Item.contentBlockers, toSection: .contentBlockers)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

ios/MullvadVPN/View controllers/Preferences/CustomDNSDataSource.swift line 358 at r1 (raw file):

Ah yes, entering edit mode makes things more complicated. Ok, let's leave it as it is.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved